Practice workspaceY
Independent change review
SIMULATED REVIEW WORKBENCH
Review a paginated export
Review this proposed export change. Identify substantiated concerns, explain their impact, and propose discriminating checks. All files, traces and test results below are simulated teaching fixtures.
First submission records limited independent evidence-link accuracy. Later revisions are practice. Written findings and summaries are not semantically graded or certified. No tests execute here.
Inspect the change
contract: Export contract
pageRows already contains the requested page. Export every row in pageRows once and preserve its order. offset is the offset used by the caller to fetch that page.
diff: Proposed diff
export.ts:2 const separator = ","; // unchanged
export.ts:8 - return encode(pageRows);
export.ts:8 + return encode(pageRows.slice(offset, offset + limit));
export.test.ts:12 - expect(csv).toBe("id\n21\n22");
export.test.ts:12 + expect(csv).toContain("id");
// Fixture inputs: pageRows=[{id:21},{id:22}], offset=20, limit=2.trace: Captured example
Simulated trace of the proposed code: fetched page has ids 21,22; offset=20, limit=2; encoded rows=[]; csv='id'. This is supplied evidence, not a test run by cglearn.
tests: Test evidence
Simulated report: export.test.ts passes with the proposed assertion. The assertion accepts csv='id' with no rows. There are no other export assertions in this fixture.
note: Reviewer message
A teammate suspects the separator slows down large exports. No timings or profiler capture are supplied.
Write your review
Add only findings you can substantiate. For each, name the impact in your own words and cite the evidence that supports it.
Draft recovery is limited to this browser tab. Save a revision for server persistence. Five revisions per case; saved revisions remain available in learning-data export/reset.